Split hidden issue counts by level

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

internal/submodule/status.go

@@ -60,21 +60,31 @@ func (s *Status) Issues() []Issue {
 	return out
 }
 
-// HiddenIssues counts the issues of all loaded descendants and returns the
-// most severe level among them. A descendant whose load failed counts as one
-// danger, since its state is unknown.
-func (m *Submodule) HiddenIssues() (count int, worst Level) {
+// Hidden counts issues below a submodule per level.
+type Hidden struct{ Warn, Danger int }
+
+// Total is the number of issues of all levels.
+func (h Hidden) Total() int { return h.Warn + h.Danger }
+
+// HiddenIssues counts the issues of all loaded descendants per level. A
+// descendant whose load failed counts as one danger, since its state is
+// unknown.
+func (m *Submodule) HiddenIssues() Hidden {
+	var h Hidden
 	Walk(m.Children, func(c *Submodule) {
 		if c.Status == nil && c.Err != nil {
-			count++
-			worst = max(worst, LevelDanger)
+			h.Danger++
 		}
 		for _, is := range c.Status.Issues() {
-			count++
-			worst = max(worst, is.Level)
+			switch is.Level {
+			case LevelDanger:
+				h.Danger++
+			case LevelWarn:
+				h.Warn++
+			}
 		}
 	})
-	return count, worst
+	return h
 }
 
 // Walk calls fn for every submodule in depth-first order.

internal/submodule/status_test.go

@@ -46,9 +46,8 @@ func TestHiddenIssues(t *testing.T) {
 	loading := &Submodule{}
 	root := &Submodule{Status: ok, Children: []*Submodule{child, {Status: ok}, loading}}
 
-	count, worst := root.HiddenIssues()
-	if count != 2 || worst != LevelDanger {
-		t.Errorf("HiddenIssues() = %d, %v; want 2, LevelDanger", count, worst)
+	if got := root.HiddenIssues(); got != (Hidden{Warn: 1, Danger: 1}) {
+		t.Errorf("HiddenIssues() = %+v; want 1 warn, 1 danger", got)
 	}
 }
 
@@ -75,7 +74,7 @@ func TestHiddenIssuesCountLoadErrors(t *testing.T) {
 	bad := &Submodule{Err: errors.New("boom")}
 	loading := &Submodule{}
 	parent := &Submodule{Children: []*Submodule{bad, loading}}
-	if n, w := parent.HiddenIssues(); n != 1 || w != LevelDanger {
-		t.Errorf("got %d, %v; want 1, danger", n, w)
+	if got := parent.HiddenIssues(); got != (Hidden{Danger: 1}) {
+		t.Errorf("got %+v; want 1 danger", got)
 	}
 }